Bug 6251 - Upgrade Eclipse plugin to Luna
Summary: Upgrade Eclipse plugin to Luna
Status: VERIFIED FIXED
Alias: None
Product: Eclipse Plugin
Classification: Yocto Project Subprojects
Component: eclipse-plugin (show other bugs)
Version: 1.7
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 1.8 M3
Assignee: Todor Minchev
QA Contact: Mihail Stanciu
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2014-04-29 11:11 UTC by Jessica
Modified: 2015-03-24 13:11 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)


Attachments
Patch to adapt org.yocto.bc.ui to Eclipse Luna (PTP 8.0+) (18.25 KB, patch)
2014-09-21 07:48 UTC, Martin Oberhuber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jessica 2014-04-29 11:11:01 UTC

    
Comment 1 Martin Oberhuber 2014-09-21 07:48:18 UTC
Created attachment 2132 [details]
Patch to adapt org.yocto.bc.ui to Eclipse Luna (PTP 8.0+)

Attached patch makes the necessary adaptations in the org.yocto.bc.ui plug-in for Eclipse 4.4 Luna (which includes PTP 8.0 which introduced an API change):

With Eclipse 4.4 Luna, the PTP/RDT project has changed the remote
services API from org.eclipse.ptp.remote to org.eclipse.remote .

This commit makes the necessary adaptations in the org.yocto.bc.ui
plug-in , and also fixes the most obvious warnings in the files that
were touched (BREE was missing in MANIFEST.MF , and the non-generic
Map has been replaced by the proper Map<String,Object> in one place.

The changes are actually quite trivial but partially look bigger than
they are, just because "organize imports" was used.

Remaining work: (1) A compiler warning informs about a possible
resource leak related to using ConsoleWriter - that warning was not
followed up on. Also (2) the new PTP remote API was introduced in order
to allow consumers leverage the remote services framework without
a dependency on PTP. The org.yocto.bc.ui does not currently leverage
this new benefit since it still uses internals from PTP/RDT in very
few places. This should be reviewed.

The patch is signed-off and ready to go. I declare that I developed attached changes from scratch myself, and I am authorized by my employer (WindRiver) to contribute attached changes under the Eclipse Public License EPL v1.0
Comment 2 Mihail Stanciu 2015-02-09 13:10:15 UTC
Is there any chance we can get an ETA on this? It would help our QA plans greatly if we had a general idea when this would be finished.

Regards,
Mihail
Comment 3 Todor Minchev 2015-02-09 13:41:06 UTC
This is already done. The plugin is adapted for Eclipse Luna.
Please retest using this repo (luna-next branch).

https://git.yoctoproject.org/cgit/cgit.cgi/eclipse-poky-luna/?h=luna-next

If you are happy with the tests, please mark this bug as resolved.

Regards,
Todor
Comment 4 Alexandru Georgescu 2015-02-09 17:32:40 UTC
(In reply to comment #3)
> This is already done. The plugin is adapted for Eclipse Luna.
> Please retest using this repo (luna-next branch).
> 
> https://git.yoctoproject.org/cgit/cgit.cgi/eclipse-poky-luna/?h=luna-next
> 
> If you are happy with the tests, please mark this bug as resolved.
> 
> Regards,
> Todor

Hi, I just tried to run the headless build on the latest http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-poky-luna/. Seems that it is downloading the 4.3 version which is Kepler:


[fed@fed scripts]$ ./setup.sh 
Getting Eclipse SDK...
--2015-02-09 19:29:07--  http://downloads.yoctoproject.org/eclipse/downloads/drops4/R-4.3-201306052000/eclipse-SDK-4.3-linux-gtk-x86_64.tar.gz
Resolving 
Connecting to 
Proxy request sent, awaiting response... 200 OK
Length: 199285473 (190M) [application/x-gzip]
Saving to: 'eclipse-SDK-4.3-linux-gtk-x86_64.tar.gz'

 4% [======>                                                                                                                                                      ] 9,585,487    136KB/s  eta 48m 9s
Comment 5 Todor Minchev 2015-02-09 18:12:17 UTC
Please use the luna-next branch, seems like you are building from master. 

I have merged these 3 trees and pushed the result to eclipse-poky-luna
for the moment:

eclipse-poky
eclipse-poky-juno
eclipse-poky-kepler

Our aim is to maintain a single repo in the future. When Beth returns
from sabbatical I'll work with her to verify that she is happy with this
arrangement. We can then "push --force" eclipse-poky-luna to
eclipse-poky and discard

eclipse-poky-juno
eclipse-poky-kepler
eclipse-poky-luna

For QA purposes please always use the *-next branch for the release you are testing. After the work in -next branches passes the QA tests it will get merged into its respective stable branch (juno, kepler or luna).  
Master will always point to the latest stable (for the moment it is kepler, but I will change it to luna after luna-next is tested).

Thanks,
Todor
Comment 6 Mihail Stanciu 2015-03-23 12:18:43 UTC
Update for future verification efforts - from mailing list:

All branches and tags from the eclipse-poky-kepler and eclipse-poky-juno
repositories will be reachable with the same branch/tag names and the
kepler or juno prefix respectively. 

The development(master) branches for juno, kepler and luna are:
juno-master
kepler-master
luna-master
master - tracks the master branch for the latest supported Eclipse
release (luna-master at present) 

This means that all code is now in eclipse-poky.
Comment 7 Mihail Stanciu 2015-03-24 13:11:35 UTC
Verified.