* Provide a link to the autobuilder in those errors submitted by it (we need to identify a link to where in the autobuilder) * Link the commit to cgit * Provide an "Open a bug" option, which should prepopulate the bug report with as much information as possible from the errors tool
Created attachment 2112 [details] Changes to the error page
A few things here from an autobuilder perspective. Obviously not all errors into error report are going to come from an autobuilder so I would suggest that the link comes from an optional flag in send-error-report. We can modify SendErrorReport.py (http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py) to link to the overall build page e.g. https://autobuilder.yoctoproject.org/main/builders/eclipse-plugin-juno/builds/36 instead of the individual step. If we want the individual step, this will have to take a bit more work. We'd probably have to embed the buildstep ID into the error log somehow. Thoughts?
(In reply to comment #2) > A few things here from an autobuilder perspective. Obviously not all errors > into error report are going to come from an autobuilder so I would suggest > that the link comes from an optional flag in send-error-report. True. Just to be clear, the web interface will only expose the error url for those errors submitted by the Autobuilder, identified as those that contain the string "yocto-autobuilder" in the submitter field. > > We can modify SendErrorReport.py > (http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/ > python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py) to link > to the overall build page e.g. > https://autobuilder.yoctoproject.org/main/builders/eclipse-plugin-juno/ > builds/36 instead of the individual step. That was Paul Eggleton's initial suggestion, although he also observed it could cause some security issues. But since such url's will only be exposed when coming from the Autobuilder, and there is no sensitive information of any kind stored in the errors tool (apart from the occasional submitter email address), the risk is probably small. Something to keep in mind though. I guess the only thing left to clarify is who should implement the change in SendErrorReport.py. Belén If we want the individual step, > this will have to take a bit more work. We'd probably have to embed the > buildstep ID into the error log somehow. > > Thoughts?
(In reply to comment #3) > (In reply to comment #2) > > A few things here from an autobuilder perspective. Obviously not all errors > > into error report are going to come from an autobuilder so I would suggest > > that the link comes from an optional flag in send-error-report. > > True. Just to be clear, the web interface will only expose the error url for > those errors submitted by the Autobuilder, identified as those that contain > the string "yocto-autobuilder" in the submitter field. > > > > > We can modify SendErrorReport.py > > (http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/ > > python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py) to link > > to the overall build page e.g. > > https://autobuilder.yoctoproject.org/main/builders/eclipse-plugin-juno/ > > builds/36 instead of the individual step. > > That was Paul Eggleton's initial suggestion, although he also observed it > could cause some security issues. But since such url's will only be exposed > when coming from the Autobuilder, and there is no sensitive information of > any kind stored in the errors tool (apart from the occasional submitter > email address), the risk is probably small. Something to keep in mind though. Right now I have, by default ERROR_REPORT_COLLECT = True in the git repo. If we default it to False we get less data from other people, but increase their security (which I'm in favor of). > > I guess the only thing left to clarify is who should implement the change in > SendErrorReport.py. Me. Just give me a command line example and let me know when the change is in. > > Belén > > If we want the individual step, > > this will have to take a bit more work. We'd probably have to embed the > > buildstep ID into the error log somehow. > > > > Thoughts? So, for clarity: We will be sending a link to: https://autobuilder.yoctoproject.org/main/builders/nightly-mips/builds/35 Not to: https://autobuilder.yoctoproject.org/main/builders/nightly-mips/builds/35/steps/Running%20Sanity%20Tests/logs/stdio One is easier than the other to do.
Shouldn't it be to: https://autobuilder.yoctoproject.org/main/builders/nightly-mips/builds/35/steps/Running%20Sanity%20Tests ? since that is the step that failed, and there may be more than one.
(In reply to comment #5) > Shouldn't it be to: > > https://autobuilder.yoctoproject.org/main/builders/nightly-mips/builds/35/ > steps/Running%20Sanity%20Tests ? since that is the step that failed, and > there may be more than one. Yes, you are right. Thanks Paul. I did try to find this page, but didn't manage. The Autobuilder can be a bit of a maze.
Created attachment 2121 [details] Changes to the error page Updated to specify the link to the failed step in the Autobuilder
So, the next step is to update the send-error-report script in order to have it be able to send the link required. Once that goes into place, I can update the autobuilder to be able to send it on a step by step basis.
Patches will cover only the links to cgit and Bugzilla. I've opened a separate issue for the Autobuilder links (bug 6736)
The new details page was merged into master, it has > > * Link the commit to cgit > > * Provide an "Open a bug" option, which should prepopulate the bug report > with as much information as possible from the errors tool Bug #6736 currently tracks the other issue which is linking to the autobuilder