Bug 6591 - Develop Toaster layer details page
Summary: Develop Toaster layer details page
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: unspecified
Hardware: All Multiple
: Medium+ enhancement
Target Milestone: 1.8 M2
Assignee: Michael Wood
QA Contact: Mihail Stanciu
URL:
Whiteboard: GUI design available
Depends on:
Blocks:
 
Reported: 2014-07-29 11:35 UTC by Belen Barros Pena
Modified: 2015-01-29 15:14 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
Design - 1.3.1 Layer details (7.69 MB, application/pdf)
2014-09-02 15:18 UTC, Belen Barros Pena
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2014-07-29 11:35:19 UTC
This is the page showing everything Toaster knows about a specific layer (from its git repo to the list of targets or machines it provides).
Comment 1 Alexandru Damian 2014-09-01 12:15:03 UTC
Merged into origin/master
Comment 2 Belen Barros Pena 2014-09-02 15:18:44 UTC
Created attachment 2104 [details]
Design - 1.3.1 Layer details
Comment 3 Belen Barros Pena 2014-09-12 13:38:00 UTC
Reopening to track the implementation work in progress
Comment 4 Michael Wood 2014-11-11 11:03:26 UTC
TODO notes from Belen:

* Breadcrumb is missing the dividers

* The layer branch is coming as "unknown branch"

* Upate the styles of the 'add layer' and 'delete layer' buttons: they
should not be inside a well and the button should have a bottom margin of
20px. Also, the 'add layer' button should not use the class .btn-primary

* Search for tables with more than 10 entries is not implemented (see
pages 25 to 27 of the design document)

* The href attribute of the icon next to the repository URL seems to be
hardcoded: it goes to a Linaro repo
(git.linaro.org/?p=openembedded/meta-linaro.git) for all layers

* If the repository subdirectory is set to '/', the information should
simply not display (right now is showing. See, for example, the
meta-angstrom layer). This applies to all other information in the "Layer
details" tab: for example, if a layer has no dependencies, the "Layer
dependencies" item in the definition list should not show (check, for
example, openembedded-core)

* The 'Branch' and 'Last commit' information are missing, although this
could be because the branch is not rebased on top of the latest changes
(poky/master I guess at this point)

* The 'build target' buttons do not work

* In the 'targets' table, target names should not be links

* In the 'targets' table, we are missing the external link to the OE
Metadata Index (see page 21 of the design document)

* The 'select machine' buttons don't work

* In the 'machines' table, the external link next to the machine name
seems to hardcoded (it goes to the same place for all machines)

* The empty states for the 'targets' tab is not in place. See page 22 of
the design document

* In the 'about' section, the <dd> items for the 'summary' and
'description' should have the line height set to 20px

* The empty state for the 'machines' tab is not in place. See page 24 of
the design document

* Notifications text: I am keen on keeping notifications consistent across
all pages, so the add and delete layer notifications in the layer details
page should be exactly the same as in the all layers page. So, for adding
layers, they should say:

"You have added 1 layer to PROJECT_NAME: LAYER_NAME"
"You have added 2 layers to PROJECT_NAME: LAYER_NAME_1, LAYER_NAME_2"

The project name is a link to 'project configuration' section in the
project page. When adding more than one layer, layer names (except the
name corresponding to the layer details page you are in) should be links
to the corresponding layer details pages.

For the layer delete, they should say:

"You have deleted 1 layer from PROJECT_NAME: LAYER_NAME "

Once again, the project name is a link to the 'project configuration'
section in the project page.
Comment 5 Mihail Stanciu 2015-01-29 15:14:24 UTC
Verified on master: 07f2eca7e9f9163ec48d3a417d8ba885a84762f3