Bug 6711 - SendErrorReport has codepath to a None command
Summary: SendErrorReport has codepath to a None command
Status: RESOLVED FIXED
Alias: None
Product: AutoBuilder
Classification: Infrastructure
Component: autobuilder (show other bugs)
Version: unspecified
Hardware: Other other
: Undecided normal
Target Milestone: ---
Assignee: Beth Flanagan
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2014-09-11 17:28 UTC by Erik Antelman
Modified: 2014-09-16 23:14 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
Signed-off-by formated patch (1.47 KB, patch)
2014-09-11 19:43 UTC, Erik Antelman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Antelman 2014-09-11 17:28:41 UTC
If ERROR_REPORT_COLLECT is not defined, it will abort the build by finding a none command. 

In master/HEAD at dc75c7eefba00dac

I think what you want is....

diff --git a/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py b/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py
index 159c33a..5441f31 100644
--- a/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py
+++ b/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py
@@ -50,6 +50,8 @@ class SendErrorReport(ShellCommand):
                     self.errorreportserver = ""
                 self.command = "if [ ! -f ~/.oe-send-error ]; then host=`hostname`; echo \"yocto-autobuilder-autogenerated-$host\" > ~/.oe-send-error; fi ; "
                 self.command += ". ./oe-init-build-env; if [ -d " + self.errordir +"/$x" + " ]; then for x in `ls " + self.errordir +" | grep error_report_`; do send-error-report " + sel
+            else:
+                self.command = "echo environment var ERROR_REPORT_COLLECT not set - Step is noop"
             self.description = ["Sending error reports"]
         ShellCommand.start(self)
Comment 1 Beth Flanagan 2014-09-11 18:38:21 UTC
Yes, this is the exact fix. Can you send me a signed-off-by patch so I can apply your work? Thanks!
Comment 2 Erik Antelman 2014-09-11 19:43:57 UTC
Created attachment 2123 [details]
Signed-off-by formated patch
Comment 3 Beth Flanagan 2014-09-16 23:14:22 UTC
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?id=2bce1599a49725e154c0b092b7f41731827b9283

Thank you for your commit. Pulled into master and production.