Bug 6714 - IRQ request for Intel SoC DTS Thermal fails
Summary: IRQ request for Intel SoC DTS Thermal fails
Status: RESOLVED FIXED
Alias: None
Product: MinnowBoard MAX Firmware
Classification: Hardware Platforms
Component: minnowmax-edk2 (show other bugs)
Version: unspecified
Hardware: MinnowBoard Max Multiple
: Medium normal
Target Milestone: Q4 2014
Assignee: Marcel Holtmann
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2014-09-12 17:27 UTC by Marcel Holtmann
Modified: 2015-02-17 21:12 UTC (History)
9 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
Modified firmware's log with _AC0 Removed (41.93 KB, application/octet-stream)
2014-11-10 05:22 UTC, Lu_Shifei
no flags Details
Original Firmware's log (41.88 KB, application/octet-stream)
2014-11-10 05:27 UTC, Lu_Shifei
no flags Details
test Firmware Image (2.03 MB, application/x-zip-compressed)
2014-11-10 05:43 UTC, Lu_Shifei
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Holtmann 2014-09-12 17:27:43 UTC
Within the init procedure of drivers/thermal/intel_soc_dts_thermal.c we get failures of EINVAL when requesting the IRQ:

[   14.519602] intel_soc_dts_thermal: request_threaded_irq ret -22
[   14.564178] intel_soc_dts_thermal: request_threaded_irq ret -22

The board is matched by the following:

{ X86_VENDOR_INTEL, X86_FAMILY_ANY, 0x37, 0, BYT_SOC_DTS_APIC_IRQ},

Is this suppose to work or are we exposing functionality that is not present on this board?

What I can tell is that the thermal zone for each CPU core is found and registered, but since the IRQ request fails, it gets later on unregistered.
Comment 1 Marcel Holtmann 2014-09-13 18:38:27 UTC
Maybe this is related to the thermal zone information:

[    1.889377] ACPI: Invalid active0 threshold
[    1.891743] thermal LNXTHERM:00: registered as thermal_zone0
[    1.891758] ACPI: Thermal Zone [TZ01] (27 C)
Comment 2 Lu_Shifei 2014-10-21 02:18:01 UTC
Hi Marcel,
1. I can not duplicate information"intel_soc_dts_thermal: request_threaded_irq ret -22
" with Yocto 3.14.4 version OS.
[   14.519602] intel_soc_dts_thermal: request_threaded_irq ret -22
[   14.564178] intel_soc_dts_thermal: request_threaded_irq ret -22

Can you tell me which version Yocto's OS and BIOS can duplicate this issue?

2.In the other words,we can duplicate information"
[    1.889377] ACPI: Invalid active0 threshold
[    1.891743] thermal LNXTHERM:00: registered as thermal_zone0
[    1.891758] ACPI: Thermal Zone [TZ01] (27 C)"

Can we removed the method "_AC0" in BIOS ASL code?
Comment 3 David_Wei 2014-10-21 13:54:14 UTC
Here is more detail: Since there is no active cooling device on Minnow Max, so Shifei plans to remove _AC0 so that following warning would disappear.

[    1.889377] ACPI: Invalid active0 threshold
Comment 4 Darren Hart 2014-11-06 22:20:29 UTC
David, thanks. I'm assigning this to you as a firmware issue. Please proxy for who is working on it, or have them get a BZ account and assign to them. Thanks.
Comment 5 Lu_Shifei 2014-11-10 05:22:52 UTC
Created attachment 2239 [details]
Modified firmware's log with _AC0 Removed

Hi Darren,
Warning message “ACPI: Invalid active0 threshold” would disappear, see log changes between “6714before.log” and “6714after.log”.
Can you test attachment’s firmware image” MNW2MAX1.X64.0074.R03.1411071600.zip” on your side? Thanks a lot!
Comment 6 Lu_Shifei 2014-11-10 05:27:28 UTC
Created attachment 2240 [details]
Original Firmware's log
Comment 7 Lu_Shifei 2014-11-10 05:43:26 UTC
Created attachment 2241 [details]
test Firmware Image
Comment 8 David_Wei 2014-11-14 00:40:45 UTC
Design and implemeantation are completed and code is checked in. Will be available by 0.75 release.
Comment 9 David_Wei 2014-12-03 02:24:02 UTC
Assign back to Marcel. Please help test the attached test image from OTC side and give feedback.
Comment 10 Stephen K Jolley 2015-01-15 23:21:09 UTC
Please respond
Comment 11 John 'Warthog9' Hawley 2015-02-10 00:29:49 UTC
I'm still seeing the original reported error on 3.19 with 0.77

[ 17.645160] intel_soc_dts_thermal: request_threaded_irq ret -22
(mind you I'm only seeing one now)

I am not seeing:

[    1.889377] ACPI: Invalid active0 threshold

so I'm going to close this.  If I'm incorrect Marcel please re-open.