Bug 6772 - license.manifest does not include u-boot
Summary: license.manifest does not include u-boot
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: deployment (show other bugs)
Version: 1.6.2
Hardware: All arm
: Medium major
Target Milestone: 2.1 M1
Assignee: Mariano Lopez
QA Contact: Bogdan Alexandru Voiculescu
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2014-09-29 06:27 UTC by Jonathan Liu
Modified: 2016-11-28 15:06 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Liu 2014-09-29 06:27:39 UTC
Setting the following in local.conf does not include u-boot in /usr/share/common-licenses/license.manifest:
COPY_LIC_DIRS = "1"
COPY_LIC_MANIFEST = "1"
Comment 1 Paul Eggleton 2014-09-29 10:32:49 UTC
Isn't this expected since u-boot isn't actually contained in the image?
Comment 2 Jonathan Liu 2014-09-29 11:21:08 UTC
For Raspberry Pi SD card images, the image contains u-boot:
https://github.com/djwillis/meta-raspberrypi/blob/master/classes/sdcard_image-rpi.bbclass
Comment 3 Paul Eggleton 2014-10-02 15:04:18 UTC
So Beth and I have discussed bootloaders not showing up in the manifest before, but perhaps what sdcard_image-rpi.bbclass does is a "new" wrinkle (although it might be generalised to any image where a certain IMAGE_FSTYPES type might cause the final image file to contain files produced by an additional recipe - syslinux within hddimg image files springs to mind).

I do agree we need to address this; but I also think it needs to be done in a way that isn't simply adding all recipes in EXTRA_IMAGEDEPENDS to the end of the manifest; there needs to be some kind of marking that indicates what has actually happened.
Comment 4 Mariano Lopez 2015-08-03 20:08:19 UTC
Sent patch for review
Comment 5 Mariano Lopez 2015-09-07 13:59:49 UTC
Every BSP layer has its own methods to build the bootloader or other packages that are deployed in the image. For example, rpi uses IMAGE_DEPENDS, qemux86 uses the dependencies in bootimage class, fsl uses a custom class to add u-boot.

So discussing this with Paul, he recommended to check for the dependencies in rootfs and bootimage and check what packages are deployed (using SSTATE_MANIFESTS) and include those in the manifest for the image file
Comment 6 Mariano Lopez 2015-09-22 19:52:38 UTC
Change to 2.0 milestone
Comment 8 Bogdan Alexandru Voiculescu 2016-02-22 15:17:51 UTC
Verified on master:

Build Configuration:
BB_VERSION        = "1.29.0"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "Ubuntu-14.04"
TARGET_SYS        = "arm-poky-linux-gnueabi"
MACHINE           = "raspberrypi2"
DISTRO            = "poky"
DISTRO_VERSION    = "2.0+snapshot-20160222"
TUNE_FEATURES     = "arm armv7ve vfp thumb neon vfpv4 callconvention-hard cortexa7"
TARGET_FPU        = "hard"
meta
meta-yocto
meta-yocto-bsp    = "master:36b43b233c841b3c09fc17e04686b4b758780963"
meta-raspberrypi  = "master:6314f668fa14473463bb777ffaf778333fea16eb"
Comment 9 Jonathan Liu 2016-11-26 02:42:02 UTC
This isn't solved because the manifest files in /usr/share/common-licenses on the rootfs still don't include u-boot.
Comment 10 Mariano Lopez 2016-11-28 15:06:59 UTC
(In reply to comment #9)
> This isn't solved because the manifest files in /usr/share/common-licenses
> on the rootfs still don't include u-boot.

It was solved but is not working because of a change. You can check the new bug 10733, why is not working.