Bug 6920 - scripts/create-pull-request does not work correctly with git 2.x
Summary: scripts/create-pull-request does not work correctly with git 2.x
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: Scripts and Tools (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.8.3
Assignee: Ed Bartosh
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2014-10-31 16:06 UTC by Cristian Iorga
Modified: 2016-11-03 12:12 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cristian Iorga 2014-10-31 16:06:35 UTC 
Issue:
poky$ scripts/create-pull-request -s "QEMU upgrade to 2.1.2" -u contrib -b ciorga/PUs
warn: No match for commit 7a6dbf75749631db018a8a060240bd5c9c99a407 found at git://git.yoctoproject.org/poky-contrib
warn: Are you sure you pushed 'HEAD' there?
ERROR: git request-pull reported an error

Under git 2.x, the following change was made:
 * Discard the accumulated "heuristics" to guess from which branch the
   result wants to be pulled from and make sure that what the end user
   specified is not second-guessed by "git request-pull", to avoid
   mistakes.  When you pushed out your 'master' branch to your public
   repository as 'for-linus', use the new "master:for-linus" syntax to
   denote the branch to be pulled.

As such, create-pull-request script no longer works correctly with the regular usage model/parameters.

A way to circumvent this is to use it like this:

scripts/create-pull-request -s "QEMU upgrade to 2.1.2" -u contrib -b ciorga/PUs -i PUs
Comment 1 Cristian Iorga 2014-10-31 16:07:41 UTC 
Investigation started.
Comment 2 Cristian Iorga 2014-10-31 16:08:08 UTC 
See discussion:
http://permalink.gmane.org/gmane.comp.version-control.git/252442