Bug 704 - bitbake parse does not handle # in the beginning of a quoted line correctly
Summary: bitbake parse does not handle # in the beginning of a quoted line correctly
Status: VERIFIED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: 1.0
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.0 M4
Assignee: Richard Purdie
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2011-02-08 14:20 UTC by Saul Wold
Modified: 2011-07-22 11:21 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saul Wold 2011-02-08 14:20:53 UTC 

    


    


      



        
          Comment 1
        

        
          Saul Wold

        

        
        

        
          2011-02-08 14:37:15 UTC
        

      






From makedepend_1.0.3.bb

DESCRIPTION = "The makedepend program reads each sourcefile in sequence \
and parses it like a C-preprocessor, processing all #include, #define, \
#undef, #ifdef, #ifndef, #endif, #if, #elif and #else directives so that \
it can correctly tell which #include, directives would be used in a \
compilation. Any #include, directives can reference files having other \
#include directives, and parsing will occur in these files as well."

DEPENDS = "xproto util-macros"
PR = "r0"

The DEPENDS line does not get parsed and makedepend will fail the config task.
If I modify the DESCRIPTION to remove the "#" from the beginning of the lines, 
makedepend's config task correctly complete with xproto being built first.

    


    


      



        
          Comment 2
        

        
          Richard Purdie

        

        
        

        
          2011-02-14 06:06:13 UTC
        

      






This is a long standing "feature" of the bitbake parser. I agree that ideally it should pick up the context though.

    


    


      



        
          Comment 3
        

        
          Richard Purdie

        

        
        

        
          2011-02-22 13:49:21 UTC
        

      






http://git.pokylinux.org/cgit.cgi/poky/commit/?id=c0f0a8ee0cac5b6dd7c7a7e584309f862e49f536 addresses this. The user will now see a big fat warning if they try and do this.

We have to do this since we're breaking a long established "behavior".

    


    


      



        
          Comment 4
        

        
          Saul Wold

        

        
        

        
          2011-07-22 11:21:06 UTC
        

      






The parser now works for makedepend