Bug 7359 - project configure padding and duplicate name details
Summary: project configure padding and duplicate name details
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 1.8
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.8 M4
Assignee: David Reyna
QA Contact: Alexandru Roman
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-02-25 00:15 UTC by David Reyna
Modified: 2015-11-26 13:20 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Reyna 2015-02-25 00:15:57 UTC
Here are refinements requested by Belen to the project config variable page.

1) The 'not set' should have the muted class applied, so that it looks in
the nice, faded, grey colour

2) When you add a custom variable, the icon-trash is a bit too close to the
variable name. If you add the following line to the default.css file ...

dt > .icon-trash { padding-left: 5px; }

... it looks much better

3) * The ³DISTRO² value now has dynamic error checking for spaces and empty string.

So the check for the empty string is not really needed. The 'save' button
is disabled whenever the text field is empty, which prevents people from
trying to save an empty value. This is a behaviour we have implemented all
across Toaster. I think we should keep the same approach here: rely on the
disables state of the 'save' button and remove the empty string message.

The check for spaces works wonderfully, but it needs a bit of space from
the text field. If you move the <span> with id distro-error-message
outside the <div> with class input-append the whole thing works out a bit
better visually.

4) We should block duplicate custom variables that only differ by upper/lower case, just as we do for reserved variables
Comment 1 Alexandru Damian 2015-02-27 11:56:34 UTC
Merged into master.
Comment 2 Alexandru Roman 2015-11-26 13:20:15 UTC
Verified.