Bug 7394 - Toaster needs to add a space to the value of IMAGE_INSTALL_append
Summary: Toaster needs to add a space to the value of IMAGE_INSTALL_append
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 1.8 M4
Assignee: David Reyna
QA Contact: Mihail Stanciu
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-03-04 16:35 UTC by Belen Barros Pena
Modified: 2015-03-31 15:00 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2015-03-04 16:35:32 UTC
If users fail to add the opening space when setting the value of the IMAGE_INSTALL_append variable, Toaster should (very nicely) add it for them.
Comment 1 David Reyna 2015-03-11 22:35:56 UTC
Belén oberved:

In one of my builds, I added the meta-webserver layer, then set
IMAGE_INSTALL_append to apache2

The build failed, so I went to check what happened. I didn't figure that
out, but I did find that the value I set for IMAGE_INSTALL_append didn't
seem to be picked up. This is the toaster-pre.conf file:

IMAGE_INSTALL_append=" apache2"
PACKAGE_CLASSES="package_rpm"
MACHINE="nuc"
SDKMACHINE="x86_64"
DISTRO="poky"
IMAGE_FSTYPES="ext3 jffs2 tar.bz2"
TOASTER_BRBE="57:1"


So the value I set is there. But when I go to variables history and check
IMAGE_INSTALL, it says the value was an empty string. The only file that
set the variable was the toaster-pre.conf file (see attached screenshot).

However, apache2 *was* installed in the image. How do I know, if the build
failed? Because the build failed after do_rootfs, so I was able to get to
the list of packages installed, since rootfs files were created.

So I am not sure what's happening here. Is it possible that the variable
history is not picking up the values set via toaster-pre.conf?

David mentions:

In Wind River we always use IMAGE_INSTALL += "foo". It may be that "_append" is processed differently than "+=", something we have observed in different parts of bitbake.

I will investigate.
Comment 2 Mihail Stanciu 2015-03-31 15:00:22 UTC
Verified on master: 5c76cebc24675edb3dff473fce9b67cedff615db