Bug 7533 - eclipse-plugin build scripts don't fail correctly.
Summary: eclipse-plugin build scripts don't fail correctly.
Status: RESOLVED FIXED
Alias: None
Product: Eclipse Plugin
Classification: Yocto Project Subprojects
Component: eclipse-plugin (show other bugs)
Version: 2.2
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.2 M2
Assignee: Tim Orling
QA Contact: Valentin Hangan
URL:
Whiteboard:
Depends on:
Blocks: 7628
  Show dependency tree
 
Reported: 2015-03-27 16:14 UTC by Beth Flanagan
Modified: 2016-07-07 14:45 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Flanagan 2015-03-27 16:14:23 UTC
The AB doesn't know when failures occur because the build scripts aren't passing failures back. Example. generate-docs.sh has been failure for 2 releases now and we never knew about it.
Comment 1 Tim Orling 2016-06-29 22:59:35 UTC
The following build had a failure of the generate-docs.sh script (in this case because xsltproc was not installed on that AB machine).

https://autobuilder.yoctoproject.org/main/builders/eclipse-plugin-kepler/builds/843/steps/Building%20Eclipse%20Plugin/logs/stdio

Bill and I have a possible fix (for the generate-doc.sh script reporting failures), which is under test.

General concept:

for DOC in ${DOCS}; do
    make DOC=${DOC} eclipse
>>    if [ $? -ne 0 ]; then
>>        fail($? make DOC failed)
>>    fi  
    cp -rf ${DOC}/eclipse/html/* ${DOC_HTML_DIR}
    cp -f ${DOC}/eclipse/${DOC}-toc.xml ${DOC_HTML_DIR}
done
Comment 2 Tim Orling 2016-06-30 16:30:19 UTC
Patch sent to yocto ML.

Steps to easily test a failure:

1. sudo chmod -x /usr/bin/xsltproc
2. build the plugin
3. build fails
4. sudo chmod +x /usr/bin/xsltproc
5. build passes

In this case, the scripts/generate-doc.sh needed to check the result of "make" and scripts/build.sh needed to check the result of the generate-doc.sh script.
Comment 3 Tim Orling 2016-07-07 14:45:12 UTC
Merged.