Bug 7626 - devtool: extract: track changes made by additional task functions
Summary: devtool: extract: track changes made by additional task functions
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: devtools / tool chain (show other bugs)
Version: 1.8
Hardware: x86 Multiple
: Low enhancement
Target Milestone: Future
Assignee: Paul Eggleton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-04-17 16:47 UTC by Paul Eggleton
Modified: 2016-02-11 17:09 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Eggleton 2015-04-17 16:47:28 UTC
Some recipes add extra functions that make changes to the source, e.g. meta/recipes-devtools/dmidecode/dmidecode_2.12.bb; it may be nice to track these as commits in the resulting git repository where possible rather than having them potentially get mixed in with other patches or remain uncommitted at the end. (The logic for this is in GitApplyTree in meta/lib/oe/patch.py and is invoked via do_patch in patch.bbclass.) The changes might be done in a task added after do_unpack or do_patch.

If we do implement this we will need to ensure this doesn't disrupt update-recipe, i.e. any commits we make would need to be marked in a similar way we mark commits from patches, and update-recipe would need to ignore those marked commits.
Comment 1 Markus Lehtonen 2015-10-01 13:36:29 UTC
AFAIU, it would be enough to track any extra changes between do_unpack() and do_patch(). That shouldn't be to hard as we're already executing the extra steps (if any). We'd just need to run them one at a time and commit possible changes to git. With certain meta tag or some other means to prevent patch creation from those commits, of course.
Comment 2 Paul Eggleton 2015-10-02 12:45:33 UTC
Indeed, that's what I was thinking. It's just a matter of implementing it.