Bug 7633 - Parser does not error out on unclosed function
Summary: Parser does not error out on unclosed function
Status: VERIFIED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: 1.7
Hardware: All Multiple
: Medium+ normal
Target Milestone: 1.9 M1
Assignee: Richard Purdie
QA Contact: Cristina Agurida
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-04-20 14:51 UTC by Paul Eggleton
Modified: 2015-06-25 10:43 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Eggleton 2015-04-20 14:51:59 UTC
If you have a recipe with an unclosed function before EOF then you'd expect an error, but you don't get one - here's a trivial reproducer:

-------- snip ---------
LICENSE = "CLOSED"
SRC_URI = ""

do_install() {
        echo "hello"

inherit autotools gettext
-------- snip ---------

This recipe builds without error. It seems the do_install function isn't even used, the default implementation is used instead.
Comment 1 Paul Eggleton 2015-05-13 09:21:54 UTC
A related issue I just discovered - apparently if your closing } is not the first character on the line it also triggers the same behaviour (the function definition is completely ignored).
Comment 3 Cristina Agurida 2015-06-25 10:43:54 UTC
Verified on master: 8ef99a00dc75c6eed87aa1bc1528614a2a27eddf