Bug 7652 - patchwork: ensure that merged patches get properly marked as such
Summary: patchwork: ensure that merged patches get properly marked as such
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchwork (show other bugs)
Version: unspecified
Hardware: All Multiple
: Medium+ enhancement
Target Milestone: 1.9 M2
Assignee: Jose Lamego
QA Contact: Alexandru Georgescu
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-04-24 09:43 UTC by Paul Eggleton
Modified: 2015-08-20 04:26 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
post-receive git hook script (1.87 KB, application/x-shellscript)
2015-05-05 19:09 UTC, Benjamin Esquivel
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Eggleton 2015-04-24 09:43:04 UTC
At the moment it seems like most of the patches for OE-Core that get merged aren't being marked as such in patchwork; this is the #1 thing that makes patchwork unusable at the moment. This may be because the code in the commit hook that does the comparison can't handle the fact that the maintainer adds their own Signed-off-by to commits before pushing.
Comment 1 Paul Eggleton 2015-04-24 09:47:11 UTC
This may be worth solving in conjunction with bug 7653.
Comment 2 Benjamin Esquivel 2015-05-05 19:09:44 UTC
Created attachment 2490 [details]
post-receive git hook script

this attachment is the base post-receive git hook script.

I also found there is a very similar version here:

https://github.com/stephenfin/patchwork/blob/master/tools/post-receive.hook

all the same but the install path.
Comment 3 Jose Lamego 2015-08-10 14:25:45 UTC
Patchwork client configuration file (.pwclientrc) was configured to new format as described in [1] including oe-core project identifiers and appropriate login data for "git" user, which are the credentials used by the hook to automatically update patch status to "Accepted" and include corresponding commit hash whenever a git-push is performed to apply a patch.

[1] https://lists.ozlabs.org/pipermail/patchwork/2014-July/001051.html