Bug 8065 - Bogus warnings for invalid PACKAGECONFIG shown for recipes with multiple versions
Summary: Bogus warnings for invalid PACKAGECONFIG shown for recipes with multiple vers...
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: deployment (show other bugs)
Version: 1.9
Hardware: All Multiple
: Medium+ normal
Target Milestone: 1.9 M2
Assignee: Robert Yang
QA Contact: Bogdan Alexandru Voiculescu
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-07-28 11:41 UTC by Jonathan Liu
Modified: 2015-09-01 08:36 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Liu 2015-07-28 11:41:52 UTC
With the following git revisions:
bitbake - bef724057f1ea81571dd3ac5a9cf862f818434b5
openembedded-core - 27d068d05239c26a3848eb101571acab54635e37

Running the following commands:
git clone git://git.openembedded.org/openembedded-core
cd openembedded-core
git clone git://git.openembedded.org/bitbake
. oe-init-build-env
sed -i "s|invalid PACKAGECONFIG: %s\" % (pn,|invalid PACKAGECONFIG: %s\" % (d.getVar('FILE', True),|" ../meta/classes/base.bbclass
echo 'PACKAGECONFIG_append_pn-busybox = " invalid"' >> conf/local.conf
bitbake -c fetch busybox

Shows the following warnings while parsing recipes:
WARNING: /home/net147/git/openembedded-core/meta/recipes-core/busybox/busybox_git.bb: invalid PACKAGECONFIG: invalid
WARNING: /home/net147/git/openembedded-core/meta/recipes-core/busybox/busybox_1.23.2.bb: invalid PACKAGECONFIG: invalid

This indicates that the PACKAGECONFIG is checked against all versions of a recipe regardless of the recipe that is actually used. This is an issue if different versions of recipes support different sets of PACKAGECONFIG values which may result in bogus warnings.
Comment 1 Jonathan Liu 2015-07-28 11:44:27 UTC
This issue was introduced by the following commit:

From be085657bbab34bb8a822682897f96871bb2d8f4 Mon Sep 17 00:00:00 2001
From: Robert Yang <liezhi.yang@windriver.com>
Date: Thu, 11 Jun 2015 02:08:41 -0700
Subject: base.class: warn for invalid PACKAGECONFIG

There may be typos or out of date values in PACKAGECONFIG, check and
warn them.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Comment 2 Ross Burton 2015-07-28 11:52:31 UTC
Whilst checking the recipes that are actually used is an arguable optimisation, I don't understand why it would be fine for some versions of recipes to have incorrect PACKAGECONFIG lines.
Comment 3 Jonathan Liu 2015-07-28 11:57:43 UTC
My issue is that I have an older version of a recipe in my own layer that takes precedence over the version in openembedded-core. The newer version in openembedded-core removed a PACKAGECONFIG that I use in the older version so I get a warning about the PACKAGECONFIG not existing in the newer version.
Comment 4 Robert Yang 2015-07-29 08:57:37 UTC
(In reply to comment #3)
> My issue is that I have an older version of a recipe in my own layer that
> takes precedence over the version in openembedded-core. The newer version in
> openembedded-core removed a PACKAGECONFIG that I use in the older version so
> I get a warning about the PACKAGECONFIG not existing in the newer version.

Maybe you need adjust the location of your PACKAGECONFIG ? How can the newer version get the older version's PACKAGECONFIG ?
Comment 5 Ross Burton 2015-07-29 10:18:16 UTC
I'm guessing the situation is that oe-core has one version of a recipe, a private layer has another version of a recipe, and a distro sets PACKAGECONFIG_pn-recipe.  At this point both recipes have the same PACKAGECONFIG set, but the flags supported may be different.

We could fix this by moving the sanity check further down the build so that it doesn't happen at parse time but when the recipe is actually built.
Comment 6 Robert Yang 2015-07-29 10:20:46 UTC
(In reply to comment #5)
> I'm guessing the situation is that oe-core has one version of a recipe, a
> private layer has another version of a recipe, and a distro sets
> PACKAGECONFIG_pn-recipe.  At this point both recipes have the same
> PACKAGECONFIG set, but the flags supported may be different.
> 
> We could fix this by moving the sanity check further down the build so that
> it doesn't happen at parse time but when the recipe is actually built.

Thanks, sounds good.
Comment 8 Bogdan Alexandru Voiculescu 2015-09-01 08:36:40 UTC
Verified on master: commit 524c590fb44d0ef9711accf2db1a21e4a3cbcfc2