Bug 8126 - Messages are missing when "IMAGE_FSTYPES" field is not properly edited
Summary: Messages are missing when "IMAGE_FSTYPES" field is not properly edited
Status: RESOLVED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 1.9
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.4 M4
Assignee: David Reyna
QA Contact: David Lopez Barriba
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-08-07 10:05 UTC by Cristina Agurida
Modified: 2017-09-07 04:40 UTC (History)
8 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: Regression (Used to work)
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cristina Agurida 2015-08-07 10:05:38 UTC 
STATUS: FAILED
BUILD: 1.9_M2.rc1: 22078d5e533e59a9aa6999abefbf6ece4e01de8d
ENVIRONMENT: Ubuntu 15.04 x86_64

STEPS TO REPRODUCE: 

1. Start Toaster in managed mode.
2. Create a project.
3. Go to the project page.
4. Select "BitBake variables". 
5. Press the change "IMAGE_FSTYPES" button.
6. Deselect all checkboxes or type an invalid string.

Expected outcome:

"You must select at least one image type" or "No image types found" messages should be shown.

Actual outcome:

There are no messages shown.
Comment 2 Alexandru Roman 2015-11-03 13:34:25 UTC 
Verified on master: e1aa897beb33171bc902207b98c8f666b9e97ad3
Comment 3 David Lopez Barriba 2016-10-24 16:20:58 UTC 
BUILD 2.2 rc4 (M4) : 4b94b498e21aeba945fe7e72a6b7c4bb0314fb83
ENVIRONMENT: Debian 4.3.0-0.bpo.1-amd64

I followed the steps above and the error still.
Comment 4 David Reyna 2017-08-30 02:42:31 UTC 
The javascript for the warning message is in the page, but it is not being activated.

What is working is that the "Save" button is correctly disabled when there are no selections, so the state is protected.

The fix and enable the warning message is to connect to display/hide state to the "Save" button enable code.
Comment 5 David Reyna 2017-08-31 05:55:44 UTC 
The 'fstypes-error-message' label was lost. Also the show/hide added to the same code as the button enable/disable.
Comment 6 David Reyna 2017-09-07 04:40:51 UTC 
commit 1ec9de893cd782c680b1498d8368ddc129efa28d