Bug 8148 - Sorting the content of the Layer/Machines table doesn't work
Summary: Sorting the content of the Layer/Machines table doesn't work
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 1.9
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.1
Assignee: Michael Wood
QA Contact: Alexandru Roman
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-08-11 10:29 UTC by Cristina Agurida
Modified: 2015-12-14 12:01 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: Regression (Used to work)
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cristina Agurida 2015-08-11 10:29:44 UTC
STATUS: FAILED
BUILD: 1.9_M2.rc2: c75cefe8a382a63f625123c156137782db118f64
ENVIRONMENT: Ubuntu 15.04 x86_64

STEPS TO REPRODUCE:

1. Open Toaster in managed mode.
2. Create a project.
3. Go to Layers page.
4. Try to sort Layer column.

Expected results:

Sorting should work as expected.

Actual results:

Sorting does not work.
This issue can be seen also in Machines page.
Comment 1 Mihail Stanciu 2015-08-11 10:35:53 UTC
An observation on this:

It looks like the link on the column head (the one that should have been setting the ordering) would reset somehow so that it would point to the same kind of ordering as the one that was being used.

So the link would go "...&orderby=name" instead of going to "...&orderby=-name".

I hope I was clear in my explanation.

Mihai
Comment 2 Belen Barros Pena 2015-08-14 08:47:21 UTC
Sorting works for me on master:a533776d6ff83b6e3e830137455b8382d002768b

Could you check and if fixed marked as resolved?

Thanks!
Comment 3 Cristina Agurida 2015-08-17 08:27:10 UTC
The issue is also present on commit a533776d6ff83b6e3e830137455b8382d002768b,
but is not 100% reproducible.
Comment 4 Michael Wood 2015-09-28 17:55:44 UTC
Sounds like this may have been a caching issue, I can't recreate this problem. Are there any further instructions on how to go about this? Or has it been fixed in current master?
Comment 5 Mihail Stanciu 2015-10-08 08:11:30 UTC
This still happens in master: eac61f37e36099f74485dab398b57f3812826d17

Here's how I managed to reproduce this every time:

Normally, when you click on the column head, you get a quick refresh of the entire page (or at least that's what it looks like when i do it).
However, there is a small delay between when you click on the table head and when the refresh starts. This issue seems to only happen if you click on the table head twice, once to initialise the refresh and another time before the refresh action "goes through".

Hope this helps to reproduce the issue.
Comment 6 Michael Wood 2015-11-12 11:56:11 UTC
Still not able to reproduce this problem. I tried throttling the network speed to see if there was a race condition on pressing order-by multiple times but it all worked as expected. You shouldn't be seeing any page refreshes when pressing order-by on the recipes table. I wonder if you're talking about the built recipes table rather than the recipes table?

/toastergui/project/2/softwarerecipes/ and 
/toastergui/project/2/machines/

/toastergui/build/2/recipes/

?

Please make sure to include the URL in reports so we know we're talking about the page.
Comment 7 Michael Wood 2015-11-13 12:16:22 UTC
set to needinfo
Comment 8 Mihail Stanciu 2015-11-13 12:23:27 UTC
(In reply to comment #6)
> Still not able to reproduce this problem. I tried throttling the network
> speed to see if there was a race condition on pressing order-by multiple
> times but it all worked as expected. You shouldn't be seeing any page
> refreshes when pressing order-by on the recipes table. I wonder if you're
> talking about the built recipes table rather than the recipes table?
> 
> /toastergui/project/2/softwarerecipes/ and 
> /toastergui/project/2/machines/
> 
> /toastergui/build/2/recipes/
> 
> ?
> 
> Please make sure to include the URL in reports so we know we're talking
> about the page.

Hi Michael,

I've just tested this and it happens on:

toastergui/project/2/layers/
toastergui/project/2/softwarerecipes/
toastergui/project/2/machines/
toastergui/project/2/images/
Comment 10 Alexandru Roman 2015-12-14 12:01:50 UTC
Verified on master 2.1_M1_RC1: 5e3e2e0cbb0a49986f4653e64c4c8d2b5461645e