Bug 8187 - The project builds table is showing all builds instead of the project builds
Summary: The project builds table is showing all builds instead of the project builds
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 1.8
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.0
Assignee: Elliot Smith
QA Contact: Alexandru Roman
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-08-20 15:34 UTC by Belen Barros Pena
Modified: 2015-09-22 07:05 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2015-08-20 15:34:52 UTC
The project builds table should only display the builds belonging to the selected project. Instead, it is showing all builds (for all projects).
Comment 1 David Reyna 2015-09-02 07:55:41 UTC
There were several issues in this defect.

1) The project page drops the 'mandatory parameters' from the URL because they do not apply, but that does cause a parameter check and redirect when the project build page is rendered.

2) The shared '_build_list_helper' was unfortunately hard coded to always go to the all builds page (the observed outcome for the defect ) when the mandatory parameters were not found, so the project build could never actually be reached.

3) The 'projectbuilds.html' page missed out on a number of database refacturing changes, so it needed to be brought up to date.
Comment 2 Elliot Smith 2015-09-04 09:39:09 UTC
I merged David's work with mine in elliot/toaster/hide_builds-8236.

Submitted v2 to the mailing list for review.
Comment 3 Elliot Smith 2015-09-21 16:02:28 UTC
Merged into bitbake master.
Comment 4 Alexandru Roman 2015-09-22 07:05:17 UTC
Verified on master: 7b86c771c80d0759c2ca0e57c46c4c966f89c49e