Created attachment 2782 [details] Design - Displaying failed build requests Those builds have no logs, no time on task associated with them, and no data whatsoever. So their build dashboard and build status item across Toaster requires special treatment. See attached design document for details.
I've applied this design to *all* failed builds in the work I've done so far. If this is how we want this to work, the work I've done is ready for review; if not, could you please supply additional information about when we should use the failed build request dashboard vs. the dashboard we usually show?
The branch is: contrib, elliot/toaster/failed_builds_display-8443
After discussion with Belen, we've decided to only show the custom dashboard for builds which fail before the BuildStarted event. (The BuildStarted event is the one which fires just after bitbake shows the banner with the layer versions, bitbake version etc.) However, to do this, we need the patches for bug 8440. These create the build object as soon as the buildTargets() command goes to bitbake and will let us catch failed "build requests". At the point when buildTargets() is called, the build can be considered "not started", as bitbake is still figuring out whether the targets are valid; so if the build fails here, it should display with the custom failed build dashboard. But when BuildStarted fires, the build proper is started, so we use the standard dashboard from this point on, even if the build fails.
Submitted RFC for branch (rebased on 8440 branch): https://lists.yoctoproject.org/pipermail/toaster/2016-February/003979.html
I did submit this for review, but the steps which make this work visible won't work until bug 8440 is fixed.
This needs to wait until we have a fix for bug 8440, which is under discussion. Please ignore the review request for now.
Submitted patches to mailing list: https://lists.yoctoproject.org/pipermail/toaster/2016-July/004997.html