Bug 8451 - readline: apply missing upstream patches
Summary: readline: apply missing upstream patches
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: unspecified
Hardware: All Multiple
: Medium normal
Target Milestone: 2.1
Assignee: Petter
QA Contact: Bogdan Alexandru Voiculescu
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-10-06 15:10 UTC by Petter
Modified: 2016-01-12 16:39 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: Unknown (Hard to categorize)
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petter 2015-10-06 15:10:51 UTC
There are a number of missing patches from upstream that isn't applied for readline 6.3 (see http://ftp.gnu.org/gnu/readline/readline-6.3-patches/ for available 6.3 patches). Ensure that they are applied and also consider adding missing patches for readline 5.2.

See the discussion in http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111321.html for some background.
Comment 1 Petter 2015-10-06 15:13:45 UTC
Fixing this in 2.0 scope has to much impact, so aim for fixing it in 2.1 instead.
Comment 2 Petter 2015-10-09 07:01:07 UTC
After input from Marko my suggestion is that we continue to use the strategy Marko has used for readline 5.2 and fetch the patches directly from upstream. See below mail discussion for further info.

http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111353.html
Comment 3 Petter 2015-11-18 11:43:28 UTC
I have started to work with this bug report and will send something up when I have been able to verify the new patches.
Comment 4 Petter 2015-11-18 12:23:13 UTC
Work-in-progress fixes can be found at:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=petmab/bug_8451

Note that the patches are not fully verified yet. When it comes to readline-5.2 no new upstream patches exists so will leave it as is (as expected).
Comment 5 Petter 2015-11-24 10:14:51 UTC
verification:

run below for qemux86-64:
$ bitbake world
$ bitbake core-image-minimal
$ bitbake core-image-sato
$ bitbake readline [ -c <relevant tasks> ]

Enable TEST_IMAGE for sato image and all tests passed.

Tested basic readline functionality with an internal test tool that creates a promt using readline() and add commands to history etc..
Comment 6 Petter 2015-12-18 17:08:11 UTC
Merge into 'master' :

7e3474c readline: apply missing upstream patches
99b9d52 readline: prepare for readline6.3 upstream patches
Comment 7 Bogdan Alexandru Voiculescu 2016-01-12 16:39:26 UTC
Verified on master: no errors. 
Build Configuration:
BB_VERSION        = "1.28.0"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "Ubuntu-14.04"
TARGET_SYS        = "x86_64-poky-linux"
MACHINE           = "qemux86-64"
DISTRO            = "poky"
DISTRO_VERSION    = "2.0+snapshot-20160112"
TUNE_FEATURES     = "m64 core2"
TARGET_FPU        = ""
meta
meta-yocto
meta-yocto-bsp    = "master:1724ffd32d1c169a2de66f2cb88ba18c56da6146"

NOTE: Preparing RunQueue
NOTE: Executing SetScene Tasks
NOTE: Executing RunQueue Tasks
core-image-sato - Ran 43 tests in 1079.564s
core-image-sato - OK - All required tests passed
NOTE: Tasks Summary: Attempted 274 tasks of which 273 didn't need to be rerun and all succeeded.
NOTE: Writing buildhistory