Bug 8611 - gcr should be buildable without gtk
Summary: gcr should be buildable without gtk
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: graphics (show other bugs)
Version: 2.1
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.0.1
Assignee: Jussi Kukkonen
QA Contact: Cristina Agurida
URL:
Whiteboard:
Depends on:
Blocks: 8396
  Show dependency tree
 
Reported: 2015-10-29 12:20 UTC by Jussi Kukkonen
Modified: 2016-02-15 08:54 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Kukkonen 2015-10-29 12:20:10 UTC 
Alexandru reports in bug 8396 that gcr depends on gtk and breaks a world build with
    DISTRO_FEATURES_remove = "x11"

gcr should work without gtk -- or if not, it should have the correct GTK3DISTROFEATURES added to the recipe.
Comment 1 Jussi Kukkonen 2015-10-29 13:39:27 UTC 
I'll just add a 
    REQUIRED_DISTRO_FEATURES = "x11"

(adding a PACKAGECONFIG[x11] is quite a bit more work for something no-one has requested...)

I guess this is 2.1 (or 2.0.1) material?
Comment 2 Richard Purdie 2015-11-06 09:46:30 UTC 
We can consider it for 2.0.1 depending on how invasive it is.
Comment 3 Ross Burton 2016-01-26 17:37:46 UTC 
Fixed in oe-core dbdcd87144cc1cd6c5d50c800c7f266aaf25ca17 for master.  Trivial to backport to Jethro.
Comment 4 Jussi Kukkonen 2016-02-10 08:37:04 UTC 
This actually got picked up to jethro already.


commit 26eb877e18ca35171641e96035f89fbacdbd1944
Author: Jussi Kukkonen <jussi.kukkonen@intel.com>
Date:   Wed Nov 25 15:05:40 2015 +0200

    gcr: Require x11 DISTRO_FEATURE
    
    This enables a world build without x11. GTK3DISTROFEATURES is not
    enough because gtk+-x11.pc is still required.
    
    Fixes [YOCTO #8611].
    
    (From OE-Core rev: b1175339287395a7ad4fe4639a73f3a1dda74358)
    
    Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
    Signed-off-by: Ross Burton <ross.burton@intel.com>
    (cherry picked from commit dbdcd87144cc1cd6c5d50c800c7f266aaf25ca17)
    Signed-off-by: Saul Wold <sgw@linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Comment 5 Cristina Agurida 2016-02-15 08:54:58 UTC 
Verified on jethro: 5b12268f6e17574999f91628a60e21711cf62ee4