The current "devtool upgrade" test in meta/lib/oeqa/selftest/devtool.py only does a basic test that upgrading a recipe with local source files works, which is not a common use case. We need to also test: 1) Upgrading a recipe pointing to a remote tarball (part of this will be verifying that the checksums get updated) 2) Upgrading a git recipe As part of these We should also validate that only relevant variables in the recipe get modified (and that they are modified appropriately)
For 2.1 the existing test was reworked to test upgrading a recipe pointing to a remote file and do more validation, plus an additional test to upgrade a recipe pointing to a git repository. We should look to see if there are any code paths not tested by these current tests and add tests to cover them.
(In reply to comment #1) > For 2.1 the existing test was reworked to test upgrading a recipe pointing > to a remote file and do more validation, plus an additional test to upgrade > a recipe pointing to a git repository. We should look to see if there are > any code paths not tested by these current tests and add tests to cover them. Thanks for the update. I will review latest code and cover it with tests.
currently the test for devtool upgrade are covering : - test_devtool_upgrade - test_devtool_upgrade_git - test_devtool_finish_upgrade_origlayer - test_devtool_finish_upgrade_otherlayer I is there any missing scenario that you identify that need to be tested ?
I would like to see what the coverage of the upgrade module (scripts/lib/devtool/upgrade.py) is - Jose is that something you have easily available?
(In reply to comment #4) > I would like to see what the coverage of the upgrade module > (scripts/lib/devtool/upgrade.py) is - Jose is that something you have easily > available? Unfortunately coverage option is not working on new framework (Bug 11582), I will do some tests on pyro and get back to you with the results.
(In reply to comment #5) > (In reply to comment #4) > > I would like to see what the coverage of the upgrade module > > (scripts/lib/devtool/upgrade.py) is - Jose is that something you have easily > > available? > > Unfortunately coverage option is not working on new framework (Bug 11582), I > will do some tests on pyro and get back to you with the results. Unfortunately coverage option is not working on new framework (Bug 11582), I will do some tests on pyro and get back to you with the results.
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > I would like to see what the coverage of the upgrade module > > > (scripts/lib/devtool/upgrade.py) is - Jose is that something you have easily > > > available? > > > > Unfortunately coverage option is not working on new framework (Bug 11582), I > > will do some tests on pyro and get back to you with the results. > > Unfortunately coverage option is not working on new framework (Bug 11582), I > will do some tests on pyro and get back to you with the results. A Bug 11786 was opened due coverage is not working properly on pyro, util that is resolved I will not be able to check what is the current coverage.
Moved to 2.5 due resources constraint
this still seems reasonable.
devtool upgrade tests were added. The remaining question here was about code coverage. I don't believe we ever figured out correct tools for code coverage of that they are practical with the system so closing the original issue a resolved. If anyone identifies areas needing further testing we will add them.