Bug 8848 - Would like to be able to share a single Kickstart partition layout definition (.wks) between several images
Summary: Would like to be able to share a single Kickstart partition layout definition...
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: Scripts and Tools (show other bugs)
Version: 2.0
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 2.1 M3
Assignee: Ed Bartosh
QA Contact: Daniel Istrate
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2015-12-22 09:57 UTC by Joshua Lock
Modified: 2016-02-17 16:01 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Lock 2015-12-22 09:57:47 UTC
We're building several images which share a standard parition layout defined in a .wks file and built through the IMAGE_CMD_wic function defined in image_types.bbclass.

Because that function looks for ${IMAGE_BASENAME}.${MACHINE}.wks and ${IMAGE_BASENAME}.wks we have to symlink our base .wks to the appropriate IMAGE_BASENAME's for the other images.

This is even messier for multiple layers that build on a shared base layer and each define images.

It would be really nice if we could define a variable, i.e. in our shared image class, that tells the image generation code where to load a shared .wks file from.
Comment 1 Ed Bartosh 2016-01-19 17:37:38 UTC
Sent implementation for review: http://lists.openembedded.org/pipermail/openembedded-core/2016-January/115798.html
Comment 3 Ed Bartosh 2016-01-22 10:24:15 UTC
the implementation of wks 'include' statement was accepted to master:
http://cgit.openembedded.org/openembedded-core/commit/?id=3695962ba4b685f304f1039978cec60d1b1712e3
Comment 4 Daniel Istrate 2016-02-17 16:01:25 UTC
Verified on master: 152914f2983c5d69001de1d46ce99547fa1e75fe

The directdisk.wks , directdisk-bootloader-config.wks and qemux86-directdisk.wks are including the common.wks.inc.

Building directdisk, directdisk-bootloader-config and qemux86-directdisk works as before.