Bug 888 - crownbay: EMGD kernel sources have INTEL CONFIDENTIAL
Summary: crownbay: EMGD kernel sources have INTEL CONFIDENTIAL
Status: RESOLVED FIXED
Alias: None
Product: BSPs
Classification: Build System, Metadata & Runtime
Component: bsps-configuration (show other bugs)
Version: 1.0
Hardware: TunnelCreek x86
: High critical
Target Milestone: 1.1
Assignee: Tom Zanussi
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks: 9032
  Show dependency tree
 
Reported: 2011-03-16 11:35 UTC by Tom Zanussi
Modified: 2016-02-02 08:28 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Zanussi 2011-03-16 11:35:39 UTC
5 of the 450 files in the EMGD 1.5 gold and 1.5.2 kernel sources have INTEL CONFIDENTIAL licenses and incorrect copyrights.  See details below.

Matt Roper of the Intel Embedded Media & Graphics Driver Group has confirmed that these are a mistake and have been corrected in the latest master.  Since I am unable to access that, he suggested we copy the licenses from the same files in the Meego kernel tree.

>> >> >OK, I looked at every file in the kernel driver, and my scan
>showed
>> >that
>> >> >those 5 are the only ones with different licenses - the others
>seem
>> >to
>> >> >have correct copyrights and GPLv2.
>> >> >
>> >> >pvr/services4/system/tnc/sysconfig.c and
>> >> >pvr/services4/system/plb/sysconfig.c
>> >> >are simple and seem only to be used by
>> >> >pvr/services4/system/common/sysconfig.c,
>> >> >but that file contains a lot which is used externally elsewhere in
>> >> >the driver, as do the defines in pvr/services4/system/tnc/systnc.h
>-
>> >I
>> >> >don't
>> >> >think it will be possible to get rid of those.
>> >> >
>> >> >pvr/services4/system/tnc/sysconfig.c,
>> >> >pvr/services4/system/plb/sysconfig.c,
>> >> >pvr/services4/system/common/sysconfig.c,
>> >> >
>> >> >contain the 'INTEL CONFIDENTIAL' license + Intel Copyright notice,
>> >which
>> >> >presumably was orignally the same as the other files in the pvr
>> >> >directory i.e. GPLv2 + Imagination Technologies Copyright
>> >> >
>> >> >while
>> >> >
>> >> >pvr/services4/system/tnc/systnc.h
>> >> >
>> >> >contains the GPLv2 + Imagination Technologies Copyright but with
>> >'INTEL
>> >> >CONFIDENTIAL' license + Intel Copyright following that.
>> >> >
>> >> >emgd/pal/Makefile.include
>> >> >
>> >> >is a Makefile containing 'INTEL CONFIDENTIAL' license + Intel
>> >Copyright.
>
Comment 1 Tom Zanussi 2011-03-16 14:27:22 UTC
The code in the files at the URL Matt Roper supplied don't have the INTEL
CONFIDENTIAL, but it's still not GPLv2, for example:

http://otc-git.bj.intel.com/git?p=emgd-kernel.git;a=blob;f=drivers/staging/emgd/pvr/services4/system/common/sysconfig.c;h=4c9946cf6ae490c99556aeae32ad6dbb1b20274f;hb=HEAD

Looks like every file in that tree has that license and not the GPLv2,
though there is a top-level GPLv2 COPYING.

Awaiting confirmation that we can use the license and copyright in the other EMGD files, for example, pvr/services4/system/common/sysutils.c in the same directory and replace the errant licenses with that.
Comment 2 Tom Zanussi 2011-03-18 16:32:50 UTC
Added to meta-intel/bernard, until the patches posted for the kernel have been pulled.

Commit 83384c3e83d69245dfe19e36b2a64c8973ad8462