Bug 9051 - IDs missing from toaster main page
Summary: IDs missing from toaster main page
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 2.1
Hardware: x86 Multiple
: Medium+ critical
Target Milestone: 2.1 M3
Assignee: Elliot Smith
QA Contact: Mihail Stanciu
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-02-04 10:08 UTC by Mihail Stanciu
Modified: 2016-02-23 10:10 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: Regression (Used to work)
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihail Stanciu 2016-02-04 10:08:57 UTC 
Elements in table on the main page are now missing IDs that were previously there.

This has caused all our tests to fail for the main page(the all builds page).
Comment 1 Elliot Smith 2016-02-04 10:11:31 UTC 
To see what the IDs should be, see the builds.html and projects.html templates in the commit before d29e4cd (which is where I started converting the affected pages to ToasterTable).
Comment 2 Elliot Smith 2016-02-04 10:28:08 UTC 
I will reinstate the "edit-columns-button" ID on the edit columns button element.

For the all builds table, Mihail will modify the test scripts to use the correct ID. The search input for that table looks like this:

<input class="input-xxlarge" id="search-input-allbuildstable" name="search" type="text" placeholder="Search all builds" value="">

So the required ID is "search-input-allbuildstable".
Comment 3 Elliot Smith 2016-02-04 10:29:26 UTC 
The projects table will also be affected. The search input's ID there is "search-input-projectstable".
Comment 4 Elliot Smith 2016-02-04 10:35:36 UTC 
Submitted to toaster mailing list for review:
https://lists.yoctoproject.org/pipermail/toaster/2016-February/003786.html
Comment 5 Elliot Smith 2016-02-23 09:46:19 UTC 
Merged into master: 6228cf8166e4543061c6f1be85cbf02daca3822c
Comment 6 Mihail Stanciu 2016-02-23 10:10:34 UTC 
Verified in 2.1_M2_rc3: 152914f2983c5d69001de1d46ce99547fa1e75fe