The design for bug 8103 included the ability to customise an image recipe, and access the custom image details pages, from the build history section of Toaster (see pages 10, 11, 14 and 15 of the design document attached to bug 8103). Those bits are missing from the current implementation. To make things a bit easier, I've summarised the changes in a new document that is attached to this entry.
Created attachment 2992 [details] Design - Accessing image customisation from build history
Do we need both the links and the buttons? Shouldn't we just have one or the other? Having two links/buttons suggests that they will take the user to different information depending on what they click.
The links appear only in the build dashboard page. They are there because contextually it is where they make more sense: close to the build outcome. The buttons are in every page within the build history section, because in practice you might decide to carry out the actions they represent from any of those pages (any of them might provide you with the bit of information you needed to make a decision: for example, you might want to customise an image recipe only if certain packages are installed in it. You will get that information in the page showing you the list of packages installed, so only after looking at that page you will be ready to select the 'customise image' option). Both labels and buttons use exactly the same wording (although they do look different). Why do you think they suggest they do different things? Is it purely because they are displayed twice? Or is it because one set shows as links and the other one as buttons?
Mainly because one set uses links and the other buttons, so they look different. I'll put both in, then.
(In reply to comment #4) > Mainly because one set uses links and the other buttons, so they look > different. > > I'll put both in, then. mmm, that makes sense. What if both were to be links, like in the attached links-instead-of-buttons.png?
Created attachment 3013 [details] links-instead-of-buttons.png
Actually, I think the buttons are better, as it's obvious they will perform actions. I'll stick with the original design, if that's OK with you.
(In reply to comment #7) > Actually, I think the buttons are better, as it's obvious they will perform > actions. I'll stick with the original design, if that's OK with you. yes, that is also fine.
How can we show a single "Customise image recipe" button when a build might actually cover multiple targets? For example, we might have put this into the build input textbox: "core-image-minimal core-image-minimal-custom zlib" (where core-image-minimal-custom is a custom image) In this case, the build was actually based on three recipes: one for a stock image, another for a custom image, and the third a software recipe. Which buttons should be displayed in this case?
Created attachment 3017 [details] Design - Accessing image customisation from build history Updated to cover the multi target builds case.
Implementation is complete, just waiting for other branches to be reviewed before I submit.
Submitted review request to toaster mailing list: https://lists.yoctoproject.org/pipermail/toaster/2016-April/004431.html
Now that the Bootstrap 3 work has been put aside momentarily, I sent a reminder to review this: https://lists.yoctoproject.org/pipermail/toaster/2016-April/004468.html
Now in bitbake master.
Created attachment 3291 [details] links missing from Build Summary This snapshot shows that the UI design in commit 6f0c5537e02c59e1c8f3b08f598dc049ff8ee098 differs from the design document in https://bugzilla.yoctoproject.org/attachment.cgi?id=2992
Steps to reproduce on commit 6f0c5537e02c59e1c8f3b08f598dc049ff8ee098 1. start toaster 2. create a project 3. build core-image-minimal 4. wait for build to finish 5. customize the build image and give it name (example core-minimal-libby) 6. wait for it to finish 7. go to he new build image Check that the links and design mentioned in https://bugzilla.yoctoproject.org/attachment.cgi?id=2992 do not match to what the UI in this commit shows.
During implementation work we agreed to remove the links in the build dashboard, so this issue can be set to verified fixed. Thanks!
Verified in commit 6f0c5537e02c59e1c8f3b08f598dc049ff8ee098 although the attachment 3017 [details] and attachment 2992 [details] show the design with build links in the head of the page just beneath the title of the build summary. It was agreed that there will be no links under there just the buttons on the left menu on the bottom.
.