Bug 9175 - Remove os.chdir from fetch/unpack logic
Summary: Remove os.chdir from fetch/unpack logic
Status: RESOLVED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: unspecified
Hardware: All Multiple
: Medium enhancement
Target Milestone: 2.2
Assignee: Richard Purdie
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-02-26 11:11 UTC by Ross Burton
Modified: 2016-09-16 16:56 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2016-02-26 11:11:49 UTC
Using chdir in the fetcher is problematic, for example uninative uses Fetch.download() directly and has to save/restore cwd.

We should audit the fetch and unpack code to ensure that absolute paths are used and there are no assumptions about cwd.

To ensure that tarballs have the right paths in -C can be passed instead of using chdir.
Comment 1 Richard Purdie 2016-09-16 16:56:32 UTC
This was cleaned up as part of http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=ab09541d5517da9b1a23923ea8f5c26ddf745084 and some of the surrounding patches.