Bug 9323 - legacy _thumb overrides is still being used in libmad recipe
Summary: legacy _thumb overrides is still being used in libmad recipe
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: graphics (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.1
Assignee: Ross Burton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-03-22 13:40 UTC by Ming Liu
Modified: 2016-04-07 15:59 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Liu 2016-03-22 13:40:25 UTC
_thumb had been dropped from OVERRIDES since the commit:

351443d71eb246a946b41f12b54d57b36fe1574e
Author: Andre McCurdy <armccurdy@gmail.com>
Date:   Tue Dec 8 17:09:57 2015 -0800

    feature-arm-thumb.inc: drop legacy _thumb and _thumb-interwork over-rides
    
    Bitbake over-rides for _thumb and _thumb-interwork are undocumented
    and are not used anywhere in oe-core or meta-oe. The logic setting up
    the thumb-interwork over-ride even seems to be reversed and nobody
    noticed, so it seems safe to assume that these over-rides are not
    used.
    
    Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
    Signed-off-by: Ross Burton <ross.burton@intel.com>


But it's still being used in libmad recipe, as follows:
......
EXTRA_OECONF_append_thumb = " --disable-aso --enable-fpm=default"
......


Could change it to:
EXTRA_OECONF_append =  "${@bb.utils.contains('TUNE_FEATURES', 'thumb', ' --disable-aso --enable-fpm=default', '', d)}"
Comment 1 Ross Burton 2016-04-07 15:59:22 UTC
Fixed in oe-core e533e634f2ac757311f7888e764227ccdc5b0de1.