Bug 9540 - Resolve string formatting issues in console-tools
Summary: Resolve string formatting issues in console-tools
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 2.2
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.3 M3
Assignee: Chen Qi
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-04-28 10:36 UTC by Joshua Lock
Modified: 2017-03-09 09:29 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Lock 2016-04-28 10:36:15 UTC 
console-tools fails to compile with compiler flags which elevate common string formatting issues into an error (-Wformat -Wformat-security -Werror=format-security).
Comment 1 Joshua Lock 2017-02-07 13:18:59 UTC 
Setting assignee to recipe maintainer. Chen Qi, please feel free to update estimate, target, etc. to suit your workload.
Comment 2 Joshua Lock 2017-02-07 13:24:01 UTC 
Note: to observe the failures comment out the recipe's SECURITY_STRINGFORMAT entry in security_cflags.inc and build the recipe with a configuration that utilises security_cflags (i.e. the poky-lsb distro).
Comment 3 Chen Qi 2017-03-09 09:29:56 UTC 
commit f5bbeae7898c1e70cebf77ccdbf75937b9cc460c
Author: Chen Qi <Qi.Chen@windriver.com>
Date:   Wed Feb 8 17:25:37 2017 +0800

    security_flags: enable string formatting check for console tools
    
    As we've fixed the string formatting issue in console-tools, we don't
    need to override SECURITY_STRINGFORMAT for console-tools any more.
    
    [YOCTO #9540]
    
    (From OE-Core rev: 3883332f84d9da0792c2c7337e842da34ea1b06c)
    
    Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
    Signed-off-by: Ross Burton <ross.burton@intel.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>