Bug 9661 - upgrade oe-selftest to python 3
Summary: upgrade oe-selftest to python 3
Status: VERIFIED FIXED
Alias: None
Product: Build Testing
Classification: QA/Testing
Component: general (show other bugs)
Version: 2.2
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.2 M1
Assignee: Leonardo Sandoval Gonzalez
QA Contact: Jose Perez C
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-05-23 16:46 UTC by Benjamin Esquivel
Modified: 2016-06-17 16:29 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
oe-selftest python 3 error log from autobuilder (33.95 KB, text/plain)
2016-05-23 16:48 UTC, Benjamin Esquivel
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Esquivel 2016-05-23 16:46:28 UTC
The following Autobuilder run shows that oe-selftest has some tests failing when the python 3 upgrade is applied

https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest/builds/517
(oe-selftest error log attached)

The work required is to make them python 3 compliant while validating they don't give false/negative positives. The build details can be gathered from the autobuilder page and the oe-selftest run procedure can be obtained from here:

https://wiki.yoctoproject.org/wiki/Oe-selftest
Comment 1 Benjamin Esquivel 2016-05-23 16:48:37 UTC
Created attachment 3184 [details]
oe-selftest python 3 error log from autobuilder
Comment 2 Richard Purdie 2016-05-23 17:02:02 UTC
https://gist.github.com/bartosh/a2aedb3c7942ffc6e55e797ee744249a are hacks Ed had when looking at this. The sorted() one may be correct, the glob one isn't correct.
Comment 3 Leonardo Sandoval Gonzalez 2016-05-30 22:21:05 UTC
Branch [1] solves 'most' of the issues originally reported.

Some comments:

1. the python3-curses need to be installed in other to pass the following tests:
test_devtool_modify_invalid (oeqa.selftest.devtool.DevtoolTests). This documentation may impact the reference manual [4].

2. there is another issue observed [2], observed from buildbot [3] but not when the test is run manually from the AB. Currently under investigation

[1] http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/?h=lsandov1%2Foe-selftest-python3

[2] 
======================================================================
FAIL: test_recipetool_appendfile_patch (oeqa.selftest.recipetool.RecipetoolTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/utils/decorators.py", line 109, in wrapped_f
    return func(*args, **kwargs)
  File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/recipetool.py", line 285, in test_recipetool_appendfile_patch
    self.fail('Patch warning not found in output:\n%s' % output)
AssertionError: Patch warning not found in output:
Parsing recipes..WARNING: File /etc/selftest-replaceme-patched is added by the patch /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta-selftest/recipes-test/recipetool/files/add-file.patch - you may need to remove or replace this patch in order to replace the file.
NOTE: Writing append file /tmp/recipetoolqaug0kdb4x/recipes-test/recipetool/selftest-recipetool-appendfile.bbappend
NOTE: Copying /tmp/recipetoolqagci9tita/testfile to /tmp/recipetoolqaug0kdb4x/recipes-test/recipetool/selftest-recipetool-appendfile/testfile
done.


[3] https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest/builds/531/steps/Running%20oe-selftest/logs/stdio

[4] http://www.yoctoproject.org/docs/2.1/ref-manual/ref-manual.html#required-packages-for-the-host-development-system
Comment 4 Leonardo Sandoval Gonzalez 2016-05-31 13:50:55 UTC
(In reply to comment #3)

> 
> 1. the python3-curses need to be installed in other to pass the following
> tests:
> test_devtool_modify_invalid (oeqa.selftest.devtool.DevtoolTests). This
> documentation may impact the reference manual [4].

Ignore this comment. I am seeing the problem even with the python3-curses installed. The root cause is something different.
Comment 6 Scott Rifenbark 2016-06-14 19:09:24 UTC
Hi, 

Is there still a documentation component to this bug?  Comment 3 indicated such but then Comment 4 basically nixed that idea.  So, can I (or someone) set the doc flag to "No" is applicable?

thanks 
Scott
Comment 7 Benjamin Esquivel 2016-06-14 19:40:37 UTC
(In reply to comment #6)
> Hi, 
> 
> Is there still a documentation component to this bug?  Comment 3 indicated
> such but then Comment 4 basically nixed that idea.  So, can I (or someone)
> set the doc flag to "No" is applicable?
> 
> thanks 
> Scott

Scott, this bug will not generate doc changes. The thing that Leo saw was that his machine was missing the python-curses package but such requirement is already covered at the 'Build Host Packages'[1] section of the mega manual.

[1] http://www.yoctoproject.org/docs/2.1/mega-manual/mega-manual.html#packages
Comment 8 Scott Rifenbark 2016-06-14 20:06:13 UTC
Thanks Benjamin for reseting the flag.
Comment 9 Jose Perez C 2016-06-17 16:29:34 UTC
Pass in latest AB builds:

#557
#556
#555

https://autobuilder.yoctoproject.org/main/builders/nightly-oe-selftest