Bug 9662 - patchdir fails silently if no trailing slash is present
Summary: patchdir fails silently if no trailing slash is present
Status: RESOLVED WORKSFORME
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.2 M4
Assignee: Carlos Rafael Giani
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-05-23 16:55 UTC by Carlos Rafael Giani
Modified: 2016-09-20 18:42 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Rafael Giani 2016-05-23 16:55:41 UTC 
When writing a recipe, I was wondering why some patches weren't being applied.
Turns out that SRC_URI lines with patchdir require a trailing slash, otherwise the patch is silently dropped.

So, a line like:

  file://fix-505.patch;patchdir=src

will cause fix-505.patch to not be applied, while

  file://fix-505.patch;patchdir=src/

will apply it.

I was using Krogoth, poky at git commit 898a78357e72fb80f1f8e26ba90bad5b7b054a4f .
Comment 1 Markus Lehtonen 2016-08-02 14:34:06 UTC 
Unfortunately I was not able to reproduce this on latest master (94d89ab75efbac4486c581a53cbd90e843c3fde4). Are you still seeing this?
Comment 2 Markus Lehtonen 2016-08-02 14:41:40 UTC 
I also tried latest Krogoth, but wasn't able to reproduce
Comment 3 Saul Wold 2016-08-31 20:46:26 UTC 
Still awaiting feedback from Carlos who is busy until beginning/mid september
Comment 4 Carlos Rafael Giani 2016-09-08 22:57:57 UTC 
It is weird. I tried several times now, but cannot reproduce this.
I recommend to close this. If I ever see this error again, I'll reopen it.
Comment 5 Stephen K Jolley 2016-09-20 18:42:32 UTC 
See last comment