Bug 9873 - patchtest-oe: in case LIC_FILES_CHKSUM changed, make sure commit message indicates the reason
Summary: patchtest-oe: in case LIC_FILES_CHKSUM changed, make sure commit message indi...
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchtest (show other bugs)
Version: 2.1
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 2.2 M2
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-07-04 16:32 UTC by Leonardo Sandoval Gonzalez
Modified: 2017-12-06 16:56 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Sandoval Gonzalez 2016-07-04 16:32:52 UTC
The suite must at least check that subject contains the string 'lic_files_chksum'  or 'license' or 'checksum' in case the value of LIC_FILES_CHKSUM would change on behalf of the corresponding patch.
Comment 1 Paul Eggleton 2016-07-06 02:16:15 UTC
By "subject" you mean "commit message" here.
Comment 2 Leonardo Sandoval Gonzalez 2016-07-06 13:47:22 UTC
(In reply to comment #1)
> By "subject" you mean "commit message" here.

patchtest at the end is using mboxes (which contain code changes in the payload), so in patchtest context is indeed a subject.
Comment 3 Paul Eggleton 2016-07-06 20:05:42 UTC
The subject is the shortlog from the commit message, not the entire commit message. LIC_FILES_CHKSUM would typically be mentioned in the commit message but not the shortlog - hence in email terms it would not actually appear in the subject, just the message body.
Comment 4 Leonardo Sandoval Gonzalez 2016-07-06 20:30:30 UTC
(In reply to comment #3)
> The subject is the shortlog from the commit message, not the entire commit
> message. LIC_FILES_CHKSUM would typically be mentioned in the commit message
> but not the shortlog - hence in email terms it would not actually appear in
> the subject, just the message body.

I see. I was a misunderstood from my part. Thanks for clarifying this.