Bug 9969 - Display target:task correctly on build dashboard (and elsewhere)
Summary: Display target:task correctly on build dashboard (and elsewhere)
Status: ACCEPTED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Medium normal
Target Milestone: Future
Assignee: Toaster default assignee
QA Contact:
URL:
Whiteboard: GUI design available
Depends on: 9631
Blocks:
  Show dependency tree
 
Reported: 2016-07-18 10:02 UTC by Elliot Smith
Modified: 2023-12-14 04:22 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
Design - Show tasks when specified (540.19 KB, application/pdf)
2016-07-18 16:55 UTC, Belen Barros Pena
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elliot Smith 2016-07-18 10:02:29 UTC
The display of target:task in the build dashboard, all builds, project builds etc. pages is inconsistent and poorly-implemented.

Because different model and template methods are used in different places, in some parts of the application, we show the target only (e.g. title for build dashboard), while in others we show target + task (e.g. all builds table).

Places where this is definitely needed:

bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html
bitbake/lib/toaster/toastergui/templates/builddashboard.html
bitbake/lib/toaster/toastergui/templates/basebuildpage.html
bitbake/lib/toaster/toastergui/templates/target.html

(NB the mrb section also displays target:task, but this is now fetched from the mostrecentbuilds API - see below.)

The fixes for 9631 include an API for getting recent builds data (mostrecentbuilds), which has some code for creating the target:task list. We also have a Build.get_sorted_targets_list() method which does part of the job.

Rationalise the code from those two places and move it to the Build model (perhaps with a custom template tag which we can also call from the mostrecentbuilds API); then apply across all parts of Toaster where we should be showing "target:task, target:task, ...".
Comment 1 Belen Barros Pena 2016-07-18 16:55:07 UTC
Created attachment 3289 [details]
Design - Show tasks when specified