| Summary: | [Hob2] Primary action button background should scale | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Hob | Reporter: | Giulia <giulia> | ||||
| Component: | hob | Assignee: | Joshua Lock - Disabled <josh> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | Medium | CC: | belen.barros.pena, giulia, jessica.zhang, jiajun.xu, josh, poky.bs.watcher, poky.watcher | ||||
| Version: | 1.2 | ||||||
| Target Milestone: | 1.2 M4 | ||||||
| Hardware: | x86 | ||||||
| OS: | Multiple | ||||||
| Whiteboard: | |||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||
| Verified: | Documentation change: | --- | |||||
| Attachments: |
|
||||||
Josh, can you help on that since you own the similar bug 2015? The problem we're having here is using gtk.Table for our layout, which uses a fixed size & placement layout policy. For the short term I've developed a patch which changes the font size to be slightly smaller ensuring it will fit all label sizes by default. Long term we should switch to using proportional layout schemes by building up gtk.Box subclasses. Two patches merged which implement the proposed workaround: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=ac53520823c37df557bffb738dfd74fe08c495be http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78fb40958a1b4ea88756f6d966c0ddfd3a543e6e Bug #2170 filed to track the switch to a non-fixed layout Short term solution works. Long term it should switch to using proportional layout schemes by building up gtk.Box subclasses. |
Created attachment 361 [details] Example of primary buttons with different label length Primary action button background is not flexible: it should scale to accommodate different label lengths (see attachment). The rule is to make the button background 49px on the left and 49px on the right wider than the text label.