Bug 2107 - [Hob2] Primary action button background should scale
Summary: [Hob2] Primary action button background should scale
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: 1.2
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.2 M4
Assignee: Joshua Lock - Disabled
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2012-03-14 17:17 UTC by Giulia
Modified: 2012-03-27 14:53 UTC (History)
7 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments
Example of primary buttons with different label length (52.83 KB, image/jpeg)
2012-03-14 17:17 UTC, Giulia
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Giulia 2012-03-14 17:17:59 UTC
Created attachment 361 [details]
Example of primary buttons with different label length

Primary action button background is not flexible: it should scale to accommodate different label lengths (see attachment). The rule is to make the button background 49px on the left and 49px on the right wider than the text label.
Comment 1 Shane Wang 2012-03-16 02:01:26 UTC
Josh, can you help on that since you own the similar bug 2015?
Comment 2 Joshua Lock - Disabled 2012-03-22 23:21:35 UTC
The problem we're having here is using gtk.Table for our layout, which uses a fixed size & placement layout policy.

For the short term I've developed a patch which changes the font size to be slightly smaller ensuring it will fit all label sizes by default.

Long term we should switch to using proportional layout schemes by building up gtk.Box subclasses.
Comment 3 Joshua Lock - Disabled 2012-03-23 17:36:20 UTC
Two patches merged which implement the proposed workaround:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=ac53520823c37df557bffb738dfd74fe08c495be

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78fb40958a1b4ea88756f6d966c0ddfd3a543e6e

Bug #2170 filed to track the switch to a non-fixed layout
Comment 4 Giulia 2012-03-27 14:53:46 UTC
Short term solution works.

Long term it should switch to using proportional layout schemes by building up gtk.Box subclasses.