Created attachment 415 [details] example of table design when rows are grouped in clusters Tables should be implemented as for visual design specification (see attachment). When tables include 'groups' like in 'Recipe by packages', please make sure all groups are collapsed when users open the tab for the first time. Groups will expand and collapse when users click on the row. It won't be possible to select a group of packages but users will be required to select packages one by one. Table headings and content display rules: - Column titles and their content should always be aligned to the left of the column (with 40 px padding) - When a row is selected the text should become bold (if what is selected belongs to a group, also the group row becomes bold to indicate something has been selected inside the group). - Column size depends on the maximum size of a content. For example the 'included' column should be small as it will only display checkboxes. Make it as big as the title but with 40px padding both on the left and right. The same is valid for the 'size' column. The 'Included' and 'Size' columns should always be aligned on the right of the table as in the design. - The 'Name' column should always be the wider one as names can be long. As for 'Brought in by', the size will depend on whether we are only displaying only one recipe/package or more (relates to bug 2182, comment 6)
Created attachment 416 [details] example of tables with no groups
Just a quick note on the attached images: the package size always displays (we display the size for both included and not included packages). If the size of a package is '0' we display '0 KB'. In the case of packages grouped by recipe, the size displayed for the recipe is the sum of the sizes of the included packages within that recipe. If no packages from a recipe are included in the image, then no size is displayed. I hope this makes sense. Belen
Created attachment 505 [details] add the 40px padding in 'name' column
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=71b277acb12353eac21fddc2531c8bac886b058b something is not followed your design, such as the padding, because I have no idea to make the showed page more pretty, so not change it, please to refer to that snapshort which be attached.
Hi Liming, The idea is that the tables in the Recipes and Packages screens should follow the design shown in pages 14 to 18 of this document: https://wiki.yoctoproject.org/wiki/images/1/1d/Hob_1.2_screens_inventory.pdf To get to that, I'll probably need to break down this bug into several, more specific bugs. For the moment, I'll use this one as a way to keep track of the need to fix those tables. Belen (In reply to comment #4) > http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/ > ?id=71b277acb12353eac21fddc2531c8bac886b058b > something is not followed your design, such as the padding, > because I have no idea to make the showed page more pretty, so not change > it, please to refer to that snapshort which be attached.
merged to master http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=71b277acb12353eac21fddc2531c8bac886b058b
Hello, I am reopening this as the design does not follow the document https://wiki.yoctoproject.org/wiki/images/1/1d/Hob_1.2_screens_inventory.pdf All the other requirements in the description seem ok. If the current design is the correct one I ask Belen to confirm, so I can set the bug to verified. Thank you.
Belen had explained the design in the mail 'Hob and image groups: feedback wanted'(yocto community), I no other advice.
Just a quick note: that email is not about this bug: it's about 2345. Cheers Belen (In reply to comment #8) > Belen had explained the design in the mail 'Hob and image groups: feedback > wanted'(yocto community), I no other advice.
Created attachment 747 [details] Recipes and packages tables Suggested changes to the recipes and packages tables. Let me know what you think. Belen
Hi Belen,I had changed the ui as your design, but the packages tree is organized by group list, so it difficult to modify the group item, because the tree mode will be as the basic source for other function, such as depends and others. Thanks! http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=limx/hob-bug-fixes-another
Hi Belen, it's merged to poky, please to review. http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=95ae927dfc8cbb0b1b8a60edb5af7c448cbc9a9e Thanks!
Hi Liming, Thanks for the good work. Just a couple of things: 1. The 'Brought in by' column is not working as designed. The number displayed between the parenthesis should be equal to the total number - 1 (i.e. minus the one that we show on the table column). For example, in the packages table, update-rc.d should be brought by udev (+4), which are: modutils-initscripts busybox netbase and keymaps So 5 in total minus udev (which we are already showing on the table) it would give us udev (+4), not udev(+5) as it is shown now. 2. I understand this might be hard to implement, but the existing packages table is just not good enough. It is really difficult to read: we have to find a way of showing a straightforward list of packages, without the groupings getting on the way. Everything else looking good :) Thanks! Belen
Hi Belen, For the 2nd issue,can we resolve it with 2346 since we're really limited on resources to have it fixed by 1.3 timeframe? Liming, For the 1st issue, can you have a quick fix per Belen's feedback? Thanks, Jessica
Sure. I'll add a note to 2346 about it. Belen (In reply to comment #14) > Hi Belen, > > For the 2nd issue,can we resolve it with 2346 since we're really limited on > resources to have it fixed by 1.3 timeframe? > > Liming, > > For the 1st issue, can you have a quick fix per Belen's feedback? > > Thanks, > Jessica
Yes I had read the 2346,and changed it as the design. Thanks!
Hi Belen, Per Liming's last note, can you verify it' inline with your design or it's still off? Thanks, Jessica
Hi Jessica, Issue number 1 in comment 13 is still not fixed. Cheers Belen (In reply to comment #17) > Hi Belen, > > Per Liming's last note, can you verify it' inline with your design or it's > still off? > > Thanks, > Jessica
Please fix the remaining item issue per Belen's comments in the hob sprint. thx! - JZ
Part of HOB improvement sprint for 1.4
In development.
Patch submitted for review.
Fixed with commit 4a3b0d7287ba7ce223021d33895bf5c953f1e4dc.
verified 33440ee70623394d06a4b214c2be10788cba6d08