Bug 2346 - [HOB] Review and refine sorting mechanisms in Hob
Summary: [HOB] Review and refine sorting mechanisms in Hob
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.4
Assignee: Cristiana Voicu
QA Contact:
URL:
Whiteboard:
Depends on: 2195
Blocks: 4194
  Show dependency tree
 
Reported: 2012-04-19 09:19 UTC by Belen Barros Pena
Modified: 2013-04-16 14:10 UTC (History)
11 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments
bug 2346 - spec.pdf (243.86 KB, application/pdf)
2012-08-22 14:42 UTC, Belen Barros Pena
no flags Details
bug 2346 - spec.pdf (253.80 KB, application/pdf)
2013-01-11 12:46 UTC, Belen Barros Pena
no flags Details
size-sorting.png (115.81 KB, image/png)
2013-01-31 12:05 UTC, Belen Barros Pena
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2012-04-19 09:19:33 UTC
Some of the issues we should tackle:

- In Recipes and Packages screens, the 'Included' heading puts the included items at the bottom on the first click, at the top on the second click. It should be the other way around (presumably, if I am sorting by 'Included', what I am interested in is the included items). 

- In the Packages screen, the grouping by recipe causes some sorting issues
(items are sorted within recipes, which results on a strange behaviour). We
need to give some thought to how sorting should behave when items are grouped
by a certain criteria (e.g by recipe).

- How to sort by 'Brought by' when something is brought by more than one item. This is linked to how to display 'Brought by' information for each item.
Comment 1 Cristian Iorga 2012-08-21 17:39:13 UTC
Hello Belen,

1. Care to go into details with the first item of the list of issues? I don't really get the problem. Altough I do agree with you that Included column should not have a sorting order property.

2. Do agree on second issue, but I do think this is a hard one to solve. As far as I can tell, the packages's presentation style dependens on the way recipes are created inside poky build system. Can you please present a proposal?

3. The third item is a hard one to solve also. Can you please present a proposal?
Comment 2 Belen Barros Pena 2012-08-22 08:32:28 UTC
Hi Cristian,

I'll be working on this bug today and tomorrow. It's interlinked with 2195 and 2248, which I am also working on right now. 

I should have something to show you by the end of this week.

Cheers

Belen

(In reply to comment #1)
> Hello Belen,
> 
> 1. Care to go into details with the first item of the list of issues? I
> don't really get the problem. Altough I do agree with you that Included
> column should not have a sorting order property.
> 
> 2. Do agree on second issue, but I do think this is a hard one to solve. As
> far as I can tell, the packages's presentation style dependens on the way
> recipes are created inside poky build system. Can you please present a
> proposal?
> 
> 3. The third item is a hard one to solve also. Can you please present a
> proposal?
Comment 3 Belen Barros Pena 2012-08-22 14:42:19 UTC
Created attachment 719 [details]
bug 2346 - spec.pdf

Hi Cristian,

Attached details about the sorting criteria for recipes and packages tables. Please note the design detailed in the document depends on bug 2195.

Belen
Comment 4 Jessica 2012-09-12 21:10:03 UTC
Change state per Belen's latest update
Comment 5 Belen Barros Pena 2012-09-18 08:53:12 UTC
This bug's fix should include removing the recipe groupings in the packages table. See 

https://bugzilla.yoctoproject.org/show_bug.cgi?id=2195#c14
Comment 6 Cristian Iorga 2012-10-15 07:47:00 UTC
Investigation started.
Comment 7 Cristian Iorga 2012-10-15 13:39:53 UTC
In development.
Comment 8 Jessica 2013-01-09 18:23:24 UTC
Per our discussion, this should be a bug not enhancement for sorting.
Comment 9 Belen Barros Pena 2013-01-11 12:46:33 UTC
Created attachment 1006 [details]
bug 2346 - spec.pdf

I've updated the design document for this bug to incorporate the changes made to the packages tables as part of 2180. I've also updated the description of the secondary sorting criteria, which before assumed you can have recipes and packages with exactly the same name (which I don't think is the case). 

The changes are only superficial, and I wouldn't think they'll affect the development estimates.

Any questions, let me know.

Belen
Comment 10 Belen Barros Pena 2013-01-31 12:05:40 UTC
Created attachment 1041 [details]
size-sorting.png

It looks like we have an issue with the Size sorting: it seems to be sorting the values as text, instead of as numeric values (see attached size-sorting.png). We should fix that as part of this bug too.
Comment 11 Cristiana Voicu 2013-03-13 13:28:44 UTC
Hi Belen,

I will work on this bug, because it is related to the others I was working on. I have a question related to the design. I saw that "All recipes" tab do not have "Licenses" column. Is a mistake in the design? If yes, you don't have to change the document, just tell me.

Thanks,
Cristiana
Comment 12 Belen Barros Pena 2013-03-20 17:47:23 UTC
(In reply to comment #11)
> Hi Belen,
> 
> I will work on this bug, because it is related to the others I was working
> on. I have a question related to the design. I saw that "All recipes" tab do
> not have "Licenses" column. Is a mistake in the design? If yes, you don't
> have to change the document, just tell me.
> 
> Thanks,
> Cristiana

My table designs did not include the licensing column in the 'All recipes' tab, that's why it's missing from the document. The license column should be sortable, with alphabetical sorting, direction A to Z (arrow up) and Z to A (arrow down).

Thanks for taking care of this!

Belen
Comment 14 Belen Barros Pena 2013-04-16 14:10:22 UTC
verified on af9ed97e30ac1a3a2b4e1062f2f8aee255d05972