At the moment if there are any warnings generated during parsing (for example, due to a missing file referred to in SRC_URI), Hob does not show these. We need to find a way of showing these to the user as they might be significant, particularly if the user is adding additional layers or modifying recipes; but we would need to do so in such a way that is not too obtrusive; i.e. we would not want to bring up a modal dialog box every time.
This bug needs design (we need to work out how to display those warnings without crowding the interface).
The design for this bug was documented in #3375 & #3376. Since they are on resolved, I will put this one also on resolved.
I am reopening this one because it refers to warnings during the recipe parsing process (after you select the machine). Such warnings cannot be displayed in the Build screen: they have to be displayed somehow in the Image configuration screen. I am also assigning the bug to myself because it needs design. Belen
Created attachment 978 [details] Bug 3215 - Displaying recipe parsing warnings.pdf A tentative design for displaying warnings thrown during the recipe parsing process. Assigning to Cristiana as agreed on IM. Feedback on the design welcome as always.
Hello Belen, The design looks good. I have only one comment. While I do understand the placement of message regarding warnings on top of image configuration tab (it suggests that is the most important thing), it does not suggests causality. Do you think it is possible to place it after machine selection widget? Regards, Cristian
I see your point there: I was between those 2 locations. Just thought it would be less intrusive at the top of the screen, which is also where we display all other notification messages (build fail, build stopped, build success are all at the top of the screen). We could definitely try displaying it below the machine combo box. If we feel it breaks the interaction flow we can always move it to the top of the screen. Cheers Belen (In reply to comment #5) > Hello Belen, > > The design looks good. > > I have only one comment. While I do understand the placement of message > regarding warnings on top of image configuration tab (it suggests that is > the most important thing), it does not suggests causality. Do you think it > is possible to place it after machine selection widget? > > Regards, > Cristian
merged to master. commit 37e025f6f9c410005e0f1dee0767e38eaec01cbd
Hi Cristiana, As agreed on our call, a list of the things we need to fix in this bug. First, the important things: - Within a Hob session, warnings are remembered across different parsings. I don't think this should work like this: the infobar and dialog should show only the warnings that apply to the latest parsing - If you get a warning infobar and then select a different machine, the infobar doesn't disappear and covers the progress bar for the parsing process. Because you don't see the progress bar, you don't know what's actually happening. And also some cosmetic things: - In the 'View warnings' dialog, we should probably align the 'Warning' heading to the text of the warning - In the 'View warnings' dialog with only one warning, the button label says 'Cancel' instead of 'Close' (it's ok in the dialog displaying multiple warnings) - In the 'View warnings' dialog, the window title looks tiny in my Fedora computer, although I am not sure if we can do something about it - In the 'View warnings' dialog, the warning text should be selectable (so I can copy and paste it to an email, for example) I've opened a bitbake bug (3783) about warnings getting cached and being displayed only once as a result. I've added 3783 to the depends list for this bug.
The changes that resolve the issues are now merged to the master. commit 5deae140808a7d1d96ffee75cab056e3fb77e535 I have remove #3783 from depends on, in order to close this bug. #3783 is a bug whihch is reproducing in bitbake. Once it is ok there, it will be ok in Hob too. Thanks, Cristiana
Verified on 8d80483e2f0f755a61087be1dffaf595fbc467fd