Bug 9665 - quoting bug in poky/scripts/contrib/mkefidisk.sh
Summary: quoting bug in poky/scripts/contrib/mkefidisk.sh
Status: RESOLVED FIXED
Alias: None
Product: General Runtime
Classification: Runtime
Component: General Runtime (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.2.2
Assignee: Saul Wold
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-05-23 22:20 UTC by Troy D. Hanson
Modified: 2017-07-18 22:32 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Patch for mkefidisk.sh (475 bytes, application/octet-stream)
2016-05-23 22:20 UTC, Troy D. Hanson 		no flags Details
Corrected patch (478 bytes, patch)
2016-05-23 23:39 UTC, Troy D. Hanson 		no flags Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Troy D. Hanson 2016-05-23 22:20:42 UTC 
Created attachment 3185 [details]
Patch for mkefidisk.sh

The attached patch corrects a quoting bug in mkefidisk.sh. The bug writes a startup.nsh with embedded control characters. This happens because \b etc are control sequences to the shell echo command. The resulting startup.nsh causes the bootup to fail, and the user is dropped into the EFI shell to manually run startup.nsh.

People following the Yocto Quick Start Guide following the Minnowboard Max example encounter the effect of this bug.
Comment 1 Troy D. Hanson 2016-05-23 23:39:26 UTC 
Created attachment 3186 [details]
Corrected patch
Comment 2 Saul Wold 2016-05-25 14:43:42 UTC 
Troy, could you please send this patch to the openembedded-core@lists.openembedded.org mailing list?  Add your comment below as the commit message.

If you are not able please assign the bug back to me and I will do it.
Comment 3 Benjamin Esquivel 2016-10-20 15:03:13 UTC 
if bug 10468 deprecates mkefidisk.sh then this change would be valid just for pre 2.3 point releases.
Comment 4 Saul Wold 2017-06-29 15:06:48 UTC 
So this is not really in a newer release yet, so a patch to master is needed first, will be provided shortly.